refactor: avoid forced style recalculation on scroll #10150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
commented
Sep 11, 2025
| ); | ||
| } | ||
|
|
||
| this.__previousScrollTop = this._scrollTop; |
There was a problem hiding this comment.
_scrollTop reads the actual scrollTop value from the DOM, which can force a style recalculation if done immediately after style writes.
vursen
changed the title
vursen
requested review from
sissbruecker,
tomivirkki and
ugur-vaadin
and removed request for
tomivirkki
sissbruecker
approved these changes
Sep 11, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the virtualizer's scroll handler to read from the cached
_scrollPositioninstead of directly from the element'sscrollTopsince that one can trigger a forced style recalculation if accessed immediately after style writes.Part of vaadin/flow-components#7985
Type of change