chore: update Aura dev page, add theme editor #10151
Conversation
jouni
force-pushed
the
chore/aura-dev-page
branch
2 times, most recently
from
ea65cb4 to
4a6dea9
Compare
web-padawan
force-pushed
the
chore/aura-dev-page
branch
from
4a6dea9 to
ea57c6d
Compare
web-padawan
changed the title
| position="top-start" | ||
| width="320px" | ||
| style="--aura-base-size: 12; --aura-base-font-size: 13" | ||
| theme |
There was a problem hiding this comment.
This affects font-size and line-height which I believe should be handled by the component.
There was a problem hiding this comment.
I’m not sure I understand what you mean.
There was a problem hiding this comment.
This is how it looks like with theme set:
And without theme:
There was a problem hiding this comment.
Not a blocker for this PR, let's look into it separately.
There was a problem hiding this comment.
Oh, right, you meant that. Yeah, that’s intentional, that some custom property values are re-evaluated on elements that have the theme attribute. This is so that a custom theme can define for example [theme~="small"] { --aura-base-size: 12; --aura-base-font-size: 12; }.
We can think of alternative selectors. The universal * selector is one option, but I thought that would probably cause performance problems.
There was a problem hiding this comment.
That button with theme="" is a mistake, though.
|
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
3 participants
Depends on #10146
Add a theme editor and more dummy content to the Aura theme dev page.
The theme editor controls have been generated by an LLM.