refactor: disable virtualizer height placeholder in grid and combo-box #10155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
tomivirkki
reviewed
Sep 12, 2025
|
tomivirkki
approved these changes
Sep 12, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All virtual elements in grid and combo-box have a CSS-defined minimum height, so there is no need for the virtualizer to check
element.offsetHeight === 0and apply a placeholder height if the intrinsic height is 0. Skipping this step prevents possible style recalculations duringvirtualizer.update(), so this method can be called multiple times without additional overhead.Part of vaadin/flow-components#7985
Type of change