chore: fix icon dev page #10159
chore: fix icon dev page #10159
Conversation
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Icon</title> | ||
| <script type="module" src="./common.js"></script> | ||
| <link rel="stylesheet" href="../packages/vaadin-lumo-styles/src/props/icons.css"> |
There was a problem hiding this comment.
The dev server should automatically inject lumo.css, which already includes icons.css, so this link might be unnecessary.
There was a problem hiding this comment.
Lumo CSS gets removed when running yarn start by default and only loaded with yarn start:lumo which breaks icons. I can modify the config to not remove all CSS files, then we can keep this.
There was a problem hiding this comment.
Well, let’s at least remove the JS import which no longer exists :)
There was a problem hiding this comment.
Pushed a change to not remove .css files from dev pages when loaded explicitly, like in case of icon.html - this should also allow to debug aura.html page when running yarn start without yarn start:aura.
|
|
This ticket/PR has been released with Vaadin 25.0.0-alpha10. |
4 participants
Replace the JS module import with the stylesheet.