fix: multi-select-combo-box-chip layout and forced color mode #10164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
approved these changes
Sep 12, 2025
| background: var(--vaadin-chip-background, var(--vaadin-background-container)); | ||
| color: var(--vaadin-chip-color, var(--vaadin-color)); | ||
| font-size: var(--vaadin-chip-font-size, 0.875em); | ||
| font-size: max(11px, var(--vaadin-chip-font-size, 0.875em)); |
There was a problem hiding this comment.
nit: max(11px, 0.875em) is also used elsewhere, could probably be refactored later if needed.
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better alignment of the remove button, and compensation for the border width, so that the chip height stays the same as the text input height.
Also, if the component height is explicitly set, keep the chips and the text input at the top, similarly to text area.