KEMBAR78
feat: add field-button part to all field buttons by web-padawan · Pull Request #10168 · vaadin/web-components · GitHub
Skip to content

feat: add field-button part to all field buttons #10168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

feat: add field-button part to all field buttons #10168

merged 1 commit into from
Sep 15, 2025

Conversation

@web-padawan
Copy link
Member

Description

Fixes #10167

Type of change

  • Feature

@web-padawan web-padawan mentioned this pull request Sep 15, 2025
Merged
@web-padawan web-padawan force-pushed the feat/field-button-part branch 3 times, most recently from 4269c68 to 210124f Compare September 15, 2025 06:57
@web-padawan web-padawan force-pushed the feat/field-button-part branch from 210124f to 4477876 Compare September 15, 2025 07:06
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jouni
jouni approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could get a way with a simple button part name? 🤔 If not, I think field-button is good enough as a name.

Not a breaking change, but we might want to point this out in the upgrading guide, for apps that still use shadow DOM styles, and haven't accounted for multiple part names on these elements.

@web-padawan
Copy link
Member Author

I was also thinking about ::part(button) but IMO using ::part(field-button) is more safe in terms of global CSS.
Yes, this will need to be reflected in the upgrading guide indeed, as [part="clear-button"] will stop working.

@web-padawan web-padawan merged commit db44120 into main Sep 15, 2025
9 checks passed
@web-padawan web-padawan deleted the feat/field-button-part branch September 15, 2025 08:00
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jouni jouni jouni approved these changes

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees

No one assigned

Labels

Released with Vaadin 25.0.0-alpha12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Styling all “field buttons” similarly is cumbersome

4 participants

@web-padawan @vaadin-bot @jouni @sissbruecker