KEMBAR78
test: stabilize flaky virtualizer test by vursen · Pull Request #10172 · vaadin/web-components · GitHub
Skip to content

test: stabilize flaky virtualizer test #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

test: stabilize flaky virtualizer test #10172

merged 1 commit into from
Sep 15, 2025

Conversation

@vursen
Copy link
Contributor

@vursen vursen commented Sep 15, 2025

Description

The PR fixes the following occasional failures:

packages/component-base/test/virtualizer-scrolling.test.js:

 ❌ virtualizer - overscroll > should prevent outer scrolling right after reaching the end
      AssertionError: expected '' to equal 'none'
      + expected - actual
      
      +none
      
      at n.<anonymous> (packages/component-base/test/virtualizer-scrolling.test.js:45:54)

Type of change

  • Internal

@vursen vursen requested a review from ugur-vaadin September 15, 2025 10:33
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vursen vursen mentioned this pull request Sep 15, 2025
Merged
1 task
@web-padawan web-padawan merged commit 20743c1 into main Sep 15, 2025
9 checks passed
@web-padawan web-padawan deleted the fix-flaky-virtualizer-test branch September 15, 2025 10:58
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@web-padawan web-padawan web-padawan approved these changes

@ugur-vaadin ugur-vaadin ugur-vaadin approved these changes

Assignees

No one assigned

Labels

Released with Vaadin 25.0.0-alpha12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vursen @vaadin-bot @web-padawan @ugur-vaadin