refactor: grid borders #10212
Merged
refactor: grid borders #10212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went through all the screenshots and they should be fine. Some of them will be updated again once I refactor how the focus outline is rendered, so it doesn't matter in this PR of the outline is partially hidden behind other rows. |
Previously rows only had just a single top/bottom border. Now they have both, so increase the row min-height by one pixel (default row border width).
jouni
commented
Sep 23, 2025
|
web-padawan
approved these changes
Sep 23, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #10190
The previous
--vaadin-grid-cell-border-widthproperty is now divided into separate--vaadin-grid-column-border-widthand--vaadin-grid-row-border-widthproperties, which can be used to set the default borders on all grids. The built-inno-row-bordersandcolumn-bordersvariants are removed, to be left for themes to add if needed.One of the reasons for this refactor is to make semi-transparent border colors look better.