fix: remove excess items from cache when size decreases #10222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
commented
Sep 24, 2025
| }); | ||
|
|
||
| it('should re-render the cell when last row leaves the viewport on resize', () => { | ||
| it('should re-render the first cell when last row leaves the viewport on resize', () => { |
There was a problem hiding this comment.
These tests relied on incorrect behavior where the grid didn't remove items exceeding the new cache size. This incorrectly resulted in the data provider not being called when the size increased again since those items were already present in the cache.
web-padawan
approved these changes
Sep 24, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes an issue where the data provider controller didn't remove excess items from the cache when its size decreased, leaving them stuck in memory until
clearCachewas explicitly called.Finding from vaadin/flow-components#8040
Type of change