feat: add markdown support to tooltip #10245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Oct 1, 2025
web-padawan
reviewed
Oct 2, 2025
web-padawan
reviewed
Oct 2, 2025
web-padawan
reviewed
Oct 2, 2025
|
Mhh, I can not reproduce that. It should be fixed by splitting up these CSS rules: |
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
force-pushed
the
feat/tooltip-markdown-support
branch
from
a9efd1a to
191bc14
Compare
My bad, was a browser caching issue (apparently web dev server config needs some tweaks to not cache CSS). |
|
web-padawan
changed the title
web-padawan
approved these changes
Oct 2, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Markdown support to
vaadin-tooltip. This introduces amarkdownproperty, which when enabled parses the tooltip content as Markdown and renders the corresponding HTML into the overlay.This adds a dependency on
vaadin-markdownto get access to therenderMarkdownToElementhelper. Similar to howvaadin-messagedynamically imports thevaadin-markdowncomponent when enabling Markdown mode, the helper is imported dynamically at runtime. This avoids pulling themarkedanddompurifydependencies into the main bundle if Markdown is not used, and instead allows code-splitting those in a separate chunk.Part of #9771
Type of change