feat: aura accent color for button, side-nav, radio-button and checkbox #10249
Conversation
| vaadin-side-nav:not(:has([slot='label']))::part(label) { | ||
| display: none; | ||
| /* Badges and other content that uses the palette inside a filled nav item */ | ||
| vaadin-side-nav[theme~='filled'] vaadin-side-nav-item[current] > :not([slot='children']) { |
There was a problem hiding this comment.
Should we change selector to ensure this doesn't affect tooltips in slot="tooltip" added in #10008?
There was a problem hiding this comment.
Yeah, should exclude tooltips as well.
| :where(:root, :host), | ||
| vaadin-button, | ||
| vaadin-menu-bar-button, | ||
| vaadin-drawer-toggle, |
There was a problem hiding this comment.
Not a blocker for this PR, just a general observation: we have some lists of components both in color.css and also surface.css, there can be presumably more of these?
While overall the code is quite self-explanatory, it would not harm to write down some short clarifications behind these at least in comments (they are minified anyways), some sort of file overview etc.
|
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
3 participants
Allow developers to customize
--aura-accent-lightand--aura-accent-darkon a component level for specific components.Define
--aura-accent-contrast-lightand--aura-accent-contrast-darkexplicitly, in addition to the compound--aura-accent-contrastproperty.Rename the Side Nave
contrastvariant tofilled.Includes a few unrelated fixes to Grid theme as well (use the property padding custom property, empty state styles).