KEMBAR78
fix: respect `--vaadin-icon-visual-size` in component icons by jouni · Pull Request #10254 · vaadin/web-components · GitHub
Skip to content

Conversation

@jouni
Copy link
Member

@jouni jouni commented Sep 29, 2025

No description provided.

@jouni jouni requested a review from web-padawan September 29, 2025 07:31
@sonarqubecloud
Copy link

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Visual tests would probably not harm, but we can add them later if needed.

@web-padawan web-padawan merged commit ee21fc1 into main Sep 29, 2025
9 checks passed
@web-padawan web-padawan deleted the fix/base-style-icon-visual-size branch September 29, 2025 08:29
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants