fix: prevent tooltip click and mousedown from bubbling to target #10268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| __onOverlayClick(event) { | ||
| // Prevent click listeners from being called when | ||
| // the tooltip is slotted into the target element | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
The button still triggers its click animation when clicking the tooltip. Maybe it would be good to fix that as well.
There was a problem hiding this comment.
Thanks, fixed. Changed to stop propagation for mousedown too - it's a better fix than the previous one. The active state used by click animation is set on mousedown event in ActiveMixin so stopping it makes sense.
|
web-padawan
changed the title
sissbruecker
approved these changes
Sep 30, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #10255
Fixes the finding from #10255 (comment)
Type of change