KEMBAR78
refactor: move Lumo props.css and global.css files to the src folder by web-padawan · Pull Request #10281 · vaadin/web-components · GitHub
Skip to content

Conversation

@web-padawan
Copy link
Member

Description

The fact that props.css and global.css files are present in the root level causes some incorrect assumptions from users about having to import them explicitly - in fact, that shouldn't be needed as both files are already included in lumo.css:

import '@vaadin/vaadin-lumo-styles/props.css';
or
import '@vaadin/vaadin-lumo-styles/utility.css';
or something else?

Type of change

  • Refactor

@web-padawan web-padawan requested review from jouni and vursen October 1, 2025 12:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@web-padawan web-padawan removed the request for review from jouni October 1, 2025 16:11
@web-padawan web-padawan merged commit c7bd508 into main Oct 1, 2025
11 of 12 checks passed
@web-padawan web-padawan deleted the refactor/move-lumo-props-css branch October 1, 2025 16:11
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants