refactor: allow global overrides of form-layout custom properties #10286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouni
force-pushed
the
fix/form-layout-base-styles
branch
from
5d98409 to
e797478
Compare
jouni
changed the title
jouni
force-pushed
the
fix/form-layout-base-styles
branch
from
e797478 to
15307a1
Compare
jouni
force-pushed
the
fix/form-layout-base-styles
branch
from
15307a1 to
42e55ed
Compare
web-padawan
reviewed
Oct 2, 2025
web-padawan
changed the title
web-padawan
force-pushed
the
fix/form-layout-base-styles
branch
from
daf4244 to
e93dff0
Compare
|
Yeah, looks fine. 8em was the default value before as well, right, so nothing changing there. |
|
web-padawan
approved these changes
Oct 2, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1156
Allow developers to override
--vaadin-form-layout-*properties on any level of the DOM hierarchy, not just on the layout host.