refactor: apply form layout row spacing using margin #10291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/form-layout-row-spacing
branch
from
b60fea9 to
fac76a8
Compare
web-padawan
changed the title
|
web-padawan
approved these changes
Oct 3, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #10290
Apply row spacing on all form layout children using margin, similarly as column spacing is applied.
Contain the margin within the host layout, to align it with how the auto-responsive layout works. This is a minor breaking change from earlier versions, that there won't be extra space before the first row and after the last row.
Don't apply the spacing on
<vaadin-form-item>which would otherwise add unnecessary space when auto-responsive layout is used (as that uses the nativegapproperty).