KEMBAR78
feat: initialize master-detail-layout package by web-padawan · Pull Request #8767 · vaadin/web-components · GitHub
Skip to content

Conversation

@web-padawan
Copy link
Member

Description

Part of vaadin/platform#7173

Added initial structure of the @vaadin/master-detail-layout package (folders, basic DOM with 2 slots, basic tests).

Type of change

  • Feature

@web-padawan web-padawan force-pushed the feat/init-md-layout-package branch 3 times, most recently from a5afd0f to d79ca8c Compare March 10, 2025 10:39
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge to main or a feature branch to be on the safe side?

@web-padawan web-padawan force-pushed the feat/init-md-layout-package branch from d79ca8c to ac65935 Compare March 12, 2025 11:13
@sonarqubecloud
Copy link

@web-padawan
Copy link
Member Author

Rebased to set version in package.json to alpha2.

Should we merge to main or a feature branch to be on the safe side?

IMO it's better to merge to main as it would be easier, otherwise we'd have to rebase again after new alpha is out.

@sissbruecker
Copy link
Contributor

Rebased to set version in package.json to alpha2.

Should we merge to main or a feature branch to be on the safe side?

IMO it's better to merge to main as it would be easier, otherwise we'd have to rebase again after new alpha is out.

Alright 👍

@web-padawan web-padawan merged commit 83d08f9 into main Mar 12, 2025
9 checks passed
@web-padawan web-padawan deleted the feat/init-md-layout-package branch March 12, 2025 13:30
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.alpha2 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants