feat: add masterSize and detailSize properties to master-detail-layout #8788
Conversation
web-padawan
force-pushed
the
feat/md-layout-size-props
branch
from
66fa369 to
1201b51
Compare
web-padawan
force-pushed
the
feat/md-layout-size-props
branch
from
1201b51 to
4aef604
Compare
| * overlaid on top of, the master area, depending on configuration and viewport size. | ||
| */ | ||
| declare class MasterDetailLayout extends ThemableMixin(ElementMixin(HTMLElement)) {} | ||
| declare class MasterDetailLayout extends ThemableMixin(ElementMixin(HTMLElement)) { |
There was a problem hiding this comment.
Is there a reason to implement ThemableMixin in new components, as shadow DOM styling is deprecated?
There was a problem hiding this comment.
I think I ended up implementing it in Card for some reason, but I didn't have a good reason (probably only because I copy-pasted from another component and couldn't make it work without it).
There was a problem hiding this comment.
Good question. I was thinking that we would still need it for Lumo styles in V24.
There was a problem hiding this comment.
Ah, right, it’s for our own needs. That was the reason in Card as well, that there isn't any other official way to load the theme stylesheets for our components.
web-padawan
force-pushed
the
feat/md-layout-size-props
branch
from
a5b4bf1 to
d46881a
Compare
packages/master-detail-layout/src/vaadin-master-detail-layout.js
Outdated
Show resolved
Hide resolved
web-padawan
changed the title
web-padawan
force-pushed
the
feat/md-layout-size-props
branch
from
56a3d4c to
c796c24
Compare
packages/master-detail-layout/test/master-detail-layout.test.js
Outdated
Show resolved
Hide resolved
packages/master-detail-layout/test/master-detail-layout.test.js
Outdated
Show resolved
Hide resolved
|
|
This ticket/PR has been released with Vaadin 24.8.0.alpha2 and is also targeting the upcoming stable 24.8.0 version. |
5 participants
Description
Part of vaadin/platform#7173
Implenented APIs for setting the size of the two areas:
masterSize/detailSize- sets a fixed size and disables flex-growmasterMinSize/detailMinSize- will be used later to detect overlay modeType of change