KEMBAR78
feat: make root heading level on dashboard customizable by ugur-vaadin · Pull Request #8885 · vaadin/web-components · GitHub
Skip to content

Conversation

@ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Apr 1, 2025

Description

This PR makes the heading level for the dashboard sections and widgets customizable by adding a property rootHeadingLevel to Dashboard.

  • The defaults are unchanged.
  • The titles are now rendered as divs instead of h2 and h3. Instead, the level is applied using the aria-level attribute on the title element.

Part of #8779

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@ugur-vaadin ugur-vaadin changed the title feat: make root heading level on dahsboard customizable feat: make root heading level on dashboard customizable Apr 1, 2025
@ugur-vaadin ugur-vaadin marked this pull request as draft April 1, 2025 07:11
@ugur-vaadin ugur-vaadin marked this pull request as ready for review April 1, 2025 10:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@ugur-vaadin ugur-vaadin merged commit 11031d7 into main Apr 7, 2025
9 checks passed
@ugur-vaadin ugur-vaadin deleted the feat-make-root-heading-level-on-dahsboard-customizable- branch April 7, 2025 17:10
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.rc2 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants