feat: implement initial version of CSSInjectionMixin #8934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/css-injection-mixin
branch
from
f897fe5 to
b9e5a3d
Compare
|
@tomivirkki Marked you as a reviewer for this PR, it's optional but your feedback would be highly appreciated. |
web-padawan
commented
Apr 14, 2025
web-padawan
force-pushed
the
feat/css-injection-mixin
branch
from
bcd96d8 to
2c34760
Compare
tomivirkki
reviewed
Apr 14, 2025
tomivirkki
reviewed
Apr 14, 2025
| } | ||
|
|
||
| // Observe custom property that would trigger injection for this class | ||
| this.#styleObserver.observe(this.#rootHost, cssInjectPropName); |
There was a problem hiding this comment.
Should this also be unobserved in componentDisconnected?
There was a problem hiding this comment.
I was thinking that maybe we could unobserve root host when there are no more components added to it (especially if it's not the document but a shadow root host). This could be implemented in a follow-up PR.
yuriy-fix
reviewed
Apr 15, 2025
web-padawan
force-pushed
the
feat/css-injection-mixin
branch
from
6fec8e8 to
1b998dc
Compare
|
yuriy-fix
approved these changes
Apr 23, 2025
|
This ticket/PR has been released with Vaadin 24.8.0.alpha6 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/platform#7453
Added
CSSInjectionMixinthat allows injecting CSS into components using the following syntax:Above styles can be injected either in a document or in a shadow root of some parent component.
Type of change
Note
Can be tested in
/dev/lumo-injection/pages using this branch:https://github.com/vaadin/web-components/tree/proto/css-injection