feat!: use stackOverlay property instead of stackThreshold #9052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
May 6, 2025
Comment on lines
-551
to
-553
| // Remove overlay attribute temporarily to detect if there is enough space | ||
| // for both areas so that layout could switch back to the split mode. | ||
| this._overlay = false; |
There was a problem hiding this comment.
This block was not needed as _overlay is already reset to false in the __detectLayoutMode() method.
sissbruecker
reviewed
May 6, 2025
packages/master-detail-layout/src/vaadin-master-detail-layout.js
Outdated
Show resolved
Hide resolved
|
sissbruecker
approved these changes
May 6, 2025
|
This ticket/PR has been released with Vaadin 24.8.0.rc2 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9048
stackThresholdproperty withstackOverlaythat defines whether the layout should use stack modestackOverlaycan now be used in combination withforceOverlayto enforce the stack mode to be usedoverlayandstackare preserved depending on which mode is used, so no changes to stylingType of change