feat: add events for backdrop click and detail Escape press #9062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
May 7, 2025
packages/master-detail-layout/src/vaadin-master-detail-layout.js
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/mdl-esc-backdrop-click
branch
from
1c9b5d9 to
7af88ca
Compare
|
sissbruecker
approved these changes
May 7, 2025
|
This ticket/PR has been released with Vaadin 24.8.0.rc2 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #9049
Added two events that can be used to determine if the detail content should be removed:
backdrop-click(only in the overlay mode)detail-esape-press(in all modes)Note: in the overlay mode some users might expect global Escape to work the same as in dialog, i.e. without the need to have detail area focused (which can happen if you click on the blank space below inputs in
detail-content).However, implementing that would be somewhat tricky as the global
keydownlistener could interfere withvaadin-overlay-escape-pressevent - so we would need to have some way to detect if Escape is being handled elsewhere. This would also require integration tests for all components that handle Escape internally, using it for clear button and closing overlay.So IMO it's easier to add explicit
keydownlistener on the detail part for now, and discuss the above case separately.Type of change