KEMBAR78
feat: message-list markdown support by tomivirkki · Pull Request #9080 · vaadin/web-components · GitHub
Skip to content

Conversation

@tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented May 8, 2025

Description

Add markdown support to <vaadin-message-list>

Fixes #8697
Related to vaadin/platform#7601

Type of change

Feature

@tomivirkki tomivirkki requested review from sissbruecker and vursen May 8, 2025 08:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

/**
* When set to `true`, the message text is parsed as Markdown.
*/
markdown: boolean | undefined;
Copy link
Contributor

@knoobie knoobie May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Instead of markdown boolean - what would you think about a property / enum mode (or format) allowing to switch between mode=text (default), mode=markdown or html or any other thing you guys might come up with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option was discussed during API design. We ended up with a markdown flag due to simplicity and because markdown also allows html content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also discussed later adding some kind of a renderer API which would allow you to decide how an item text gets rendered inside the message. That's not included in the current scope though.

@tomivirkki tomivirkki merged commit df7e517 into main May 8, 2025
9 checks passed
@tomivirkki tomivirkki deleted the feat/message-list-markdown branch May 8, 2025 13:20
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.rc2 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MessageList to support Markdown syntax

4 participants