refactor!: remove vaadin-combo-box-light element #9168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
v25/drop-combo-box-light
branch
2 times, most recently
from
f6c3da8 to
7edb040
Compare
web-padawan
commented
May 15, 2025
| }); | ||
| }); | ||
|
|
||
| describe('nested template', () => { |
There was a problem hiding this comment.
Removing this test instead of fixing it as we'll also remove polymer-legacy-adapter in V25 anyway.
web-padawan
force-pushed
the
v25/drop-combo-box-light
branch
from
7edb040 to
0cfae13
Compare
sissbruecker
approved these changes
May 19, 2025
|
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed internally, this component is no longer needed and can be removed. It has no Flow counterpart.
The purpose of this component was originally to support providing a custom input component.
Nowadays we recommend using slotted
<input>and setting CSS class names on it:Type of change