refactor!: update all components to be based on LitElement #9218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
v25/polymer-to-lit-switch
branch
from
accade7 to
607c070
Compare
web-padawan
force-pushed
the
v25/polymer-to-lit-switch
branch
4 times, most recently
from
080b0e8 to
2238f47
Compare
web-padawan
force-pushed
the
v25/polymer-to-lit-switch
branch
from
2238f47 to
ebb1733
Compare
1 task
| placeholder: { | ||
| type: String, | ||
| observer: '_placeholderChanged', | ||
| reflectToAttribute: true, |
There was a problem hiding this comment.
There were some other mixin changes like this, and for the selected attribute in tabs. This is to satisfy the snapshot tests?
There was a problem hiding this comment.
Yes, the problem is that Polymer detects cases where property declaration is overridden but we don't have that with PolylitMixin.
|
sissbruecker
approved these changes
May 20, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9035
See individual commits for every package. Some notable changes:
nextUpdate()to a couple of snapshot tests where needed<dom-repeat>autocapitalizebeing reset in email-field and password-fieldvaadin-messagewhich seem to be correctType of change