fix!: replace paragraph in login form footer with div #9593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
vursen
approved these changes
Jul 1, 2025
web-padawan
force-pushed
the
refactor/login-additional-information
branch
from
8e55b6b to
8204d11
Compare
|
This was referenced Jul 7, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usage of
<p>is problematic as it doesn't havepartand is affected by default browser margins that cause this:This PR fixes that by using
<div>to ensure footer has 0 height when no additional information / footer content is set.Type of change