refactor!: update tooltip overlay to use native popover #9760
Conversation
| super.updated(props); | ||
|
|
||
| if (props.has('text') || props.has('generator') || props.has('context')) { | ||
| this.__updateContent(); |
There was a problem hiding this comment.
I'm not sure about this method. It mainly exists because of an ugly internal hack which is likely used in some customer project and relies on patching _renderer. Maybe we can just break that assumption and inline setting textContent here in updated().
There was a problem hiding this comment.
Doesn't really hurt to keep it.
|
| _hideTooltip(immediate) { | ||
| const tooltip = this._tooltipController && this._tooltipController.node; | ||
| if (tooltip) { | ||
| this._tooltipController.setContext({ item: null }); |
There was a problem hiding this comment.
Previously, tooltip was preserving the text after closing, which is rather unexpected. Tests didn't catch that because the IT assertion returned null if no vaadin-tooltip-overlay was found in the document.
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
3 participants
Description
Fixes #9712
Type of change