refactor!: update rich-text-editor to render link dialog in light DOM #9772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Jul 18, 2025
| </div> | ||
| <vaadin-confirm-dialog | ||
| id="linkDialog" |
There was a problem hiding this comment.
I removed all the IDs from the dialog. They were not usable for referencing elements anymore, and the IDs of the slotted dialog content are in the light DOM, where we shouldn't have any IDs in general. Technically someone might have used these for targetting styles, the alternative would then be to target the slot attribute.
web-padawan
reviewed
Jul 18, 2025
|
web-padawan
approved these changes
Jul 18, 2025
web-padawan
changed the title
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Render the link dialog as slotted content in the light DOM.
Fixes #9710
Type of change