refactor!: update confirm dialog overlay to use native popover #9776
Conversation
There was a problem hiding this comment.
I'm not sure if we should expose these on the host. They seem only necessary for internal styling purposes, though someone might have used them in custom styles.
| :host([opening]), | ||
| :host([closing]) { | ||
| display: contents !important; | ||
| } |
There was a problem hiding this comment.
This is kind of a new concept, but we need it to hide the dialog from the accessibility tree when closed.
I also wonder if something like this should have been in the tooltip PR, as the tooltip now also shows up in the accessibility tree.
# Conflicts: # packages/confirm-dialog/src/vaadin-confirm-dialog-mixin.js # packages/confirm-dialog/test/confirm-dialog.test.js # packages/confirm-dialog/test/dom/__snapshots__/confirm-dialog.test.snap.js
| * Also, the `theme` attribute value set on `<vaadin-confirm-dialog>` is propagated to the | ||
| * `<vaadin-confirm-dialog-overlay>` component. |
There was a problem hiding this comment.
I wonder if we can remove this? Technically you could use it with injected shadow root styles.
There was a problem hiding this comment.
Let's keep theme propagation for now and remove it in V26. We probably should mention it as deprecated in docs. It would be good to create a separate issue about that.
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
3 participants
Description
Fixes #9706
Depends on #9775
Type of change