refactor!: remove backdrop part from overlays that do not use it #9782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
sissbruecker
approved these changes
Jul 21, 2025
| expect(overlay.owner).to.equal(group); | ||
| }); | ||
|
|
||
| it('should export all overlay parts for styling', () => { |
There was a problem hiding this comment.
We could add similar tests for Select and Tooltip.
There was a problem hiding this comment.
Added a test for tooltip since it's modified in this PR. I'll add one for Select separately.
|
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9778
Removed
backdroppart from the following components:vaadin-avatar-group-overlayvaadin-combo-box-overlayvaadin-multi-select-combo-box-overlayvaadin-rich-text-editor-popup-overlayvaadin-time-picker-overlayvaadin-tooltip-overlayvaadin-user-tags-overlayType of change