refactor!: move crud confirm dialogs to light DOM #9783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
commented
Jul 21, 2025
| newButton = crud.querySelector('[slot=new-button]'); | ||
| saveButton = crud.querySelector('[slot=save-button]'); | ||
| cancelButton = crud.querySelector('[slot=cancel-button]'); | ||
| cancelButton = crud.querySelector(':scope > [slot=cancel-button]'); |
There was a problem hiding this comment.
Selector looks a bit random without context. Maybe we should make them consistent? There's a lot of them through...
|
|
||
| /** | ||
| * Override update to render slotted link dialog into light DOM after rendering shadow DOM. | ||
| * Override update to render slotted overlays into light DOM after rendering shadow DOM. |
There was a problem hiding this comment.
Fixed the comment here, missed to do that in the previous PR.
web-padawan
approved these changes
Jul 21, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move CRUD confirm dialogs to the light DOM, so that their overlay shadow parts can be targeted with CSS.
Note: Both CRUD and confirm dialog use these same slots:
header,cancel-button. Targeting the CRUD header for example requires usingvaadin-crud > [slot="header"]specifically in order to not target the confirm dialog header. That is already the recommended selector in the docs.Fixes #9708
Type of change