refactor!: update combo-box overlay to use native popover #9815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/native-popover-combo-box
branch
2 times, most recently
from
a3d1983 to
c580703
Compare
web-padawan
commented
Jul 28, 2025
| connectedCallback() { | ||
| super.connectedCallback(); | ||
|
|
||
| const hostDir = this._getHostDir(); |
There was a problem hiding this comment.
This stopped working because with native popover, overlay no longer gets re-connected while opening.
So I replaced it with .dir="${this.dir}" for combo-box & MSCB, and dir="ltr" for the time-picker.
web-padawan
force-pushed
the
refactor/native-popover-combo-box
branch
from
62f176c to
2b6b1c0
Compare
web-padawan
force-pushed
the
refactor/native-popover-combo-box
branch
from
2b6b1c0 to
8217970
Compare
sissbruecker
approved these changes
Jul 29, 2025
web-padawan
force-pushed
the
refactor/native-popover-combo-box
branch
from
6c9ca3a to
7b508d7
Compare
|
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9721
Depends on #9814
Updated
vaadin-combo-boxto use nativepopoverfor the overlay.Also removed no longer needed
bringToFront()workaround (same change was done forvaadin-date-picker).Type of change
Note
Flow components branch: https://github.com/vaadin/flow-components/compare/proto/combo-native-popover