KEMBAR78
refactor!: update user-tags overlay to use native popover by web-padawan · Pull Request #9820 · vaadin/web-components · GitHub
Skip to content

refactor!: update user-tags overlay to use native popover #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2025
Merged

refactor!: update user-tags overlay to use native popover #9820

merged 3 commits into from
Jul 30, 2025

Conversation

@web-padawan
Copy link
Member

Description

Fixes

  • Changed vaadin-user-tags to render vaadin-user-tag elements in the light DOM and set part attribute,
  • Removed extra <div part="tags"> wrapper and updated part="content" to be a flex container instead,
  • Also added exportparts attribute to export the overlay stylable parts so that they can be used as follows:
vaadin-checkbox-group::part(user-tags-overlay) {
  background-color: green;
}

vaadin-checkbox-group::part(user-tags-content) {
  border: solid 1px red;
}

vaadin-checkbox-group::part(user-tag) {
  border: solid 1px white;
}

Type of change

  • Breaking change

@web-padawan web-padawan requested a review from sissbruecker July 29, 2025 11:33
@web-padawan web-padawan force-pushed the refactor/native-popover-user-tags branch from 2d2c0e4 to 8dc0507 Compare July 29, 2025 11:58
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

web-padawan
web-padawan commented Jul 29, 2025
View reviewed changes
packages/field-highlighter/src/vaadin-user-tags.js
get wrapper() {
return this.$.overlay.querySelector('[part="tags"]');
// Used by Collaboration Kit util
return this;
Copy link
Member Author

@web-padawan web-padawan Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to keep wrapper getter to make the Collaboration Kit helper code work.

@web-padawan web-padawan merged commit 430329c into main Jul 30, 2025
10 checks passed
@web-padawan web-padawan deleted the refactor/native-popover-user-tags branch July 30, 2025 14:03
@sissbruecker sissbruecker mentioned this pull request Jul 30, 2025
Closed
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees

No one assigned

Labels

Released with Vaadin 25.0.0-beta2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@web-padawan @vaadin-bot @sissbruecker