refactor!: update vaadin-overlay to use native popover by default #9848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| firstUpdated() { | ||
| super.firstUpdated(); | ||
|
|
||
| this.popover = 'manual'; |
There was a problem hiding this comment.
Since this is set here, should we remove setting the property from individual components as well?
There was a problem hiding this comment.
Sounds reasonable to me. Moved the logic to OverlayMixin and removed it from component templates.
|
sissbruecker
approved these changes
Jul 31, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9822
Type of change
Note
Screenshots for overlay with backdrop have been updated: previously, the overlay from the first test remained opened, and having two overlays on top of each other caused a bigger shadow. This is no longer the case with
popover.