refactor!: update components root level entryponts to not use Lumo #9898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Aug 5, 2025
|
|
||
| it('should place correct elements in the overflow menu', () => { | ||
| // FIXME: restore after updating to use base styles by default | ||
| it.skip('should place correct elements in the overflow menu', () => { |
There was a problem hiding this comment.
This seems to fail because of core dialog styles, should work after switching to base styles.
web-padawan
commented
Aug 5, 2025
|
|
||
| it('should restore previous cell content if overlay is closed', async () => { | ||
| // FIXME: restore after updating to use base styles by default | ||
| it.skip('should restore previous cell content if overlay is closed', async () => { |
There was a problem hiding this comment.
This test seems to fail locally also on main, I'll investigate how to fix it with updating to base styles.
web-padawan
force-pushed
the
refactor/root-entrypoints-src
branch
from
3ddf5f1 to
a28819c
Compare
|
vursen
approved these changes
Aug 5, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #9899
Changed root level entrypoints to import from
srcfolders.I'll create a separate PR for removing Lumo theme folders.
Type of change
Note
Notification snapshot changed as
openingattribute is not removing if there is no animation. I'll create a separate issue.