KEMBAR78
Fix un-transpiled client file with rewrites by ijjk · Pull Request #16453 · vercel/next.js · GitHub
Skip to content

Fix un-transpiled client file with rewrites #16453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2020
Merged

Fix un-transpiled client file with rewrites #16453

merged 4 commits into from
Aug 21, 2020

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Aug 21, 2020

This fixes a client-side file not being transpiled correctly when rewrites are used. The cross browser tests have been updated to make sure there are rewrites so the related code is included and not dead-code eliminated'

Closes: #16440

@ijjk
Copy link
Member Author

ijjk commented Aug 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 12.2s 12.1s -93ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +161 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.231 2.155 -0.08
/ avg req/sec 1120.79 1159.98 +39.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.24 1.211 -0.03
/error-in-render avg req/sec 2016.49 2063.85 +47.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 13.9s 13.8s -170ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +161 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
routerDirect.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
withRouter.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
Overall change 5.27 MB 5.28 MB ⚠️ +8.3 kB
Commit: 82a2b55

@ijjk
Copy link
Member Author

ijjk commented Aug 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 13.6s 13.4s -265ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +41 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.517 2.578 ⚠️ +0.06
/ avg req/sec 993.31 969.79 ⚠️ -23.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.549 1.546 0
/error-in-render avg req/sec 1613.66 1616.65 +2.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 15.6s 15.1s -518ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +41 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
routerDirect.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
withRouter.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
Overall change 5.27 MB 5.28 MB ⚠️ +8.3 kB
Commit: a89236c

@ijjk
Copy link
Member Author

ijjk commented Aug 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 10.2s 10.3s ⚠️ +103ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +41 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.852 1.85 0
/ avg req/sec 1349.78 1351.65 +1.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.005 1.046 ⚠️ +0.04
/error-in-render avg req/sec 2488.14 2389.92 ⚠️ -98.22
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
buildDuration 11.8s 11.6s -148ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +41 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e8a0282..7b6f.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-90cf36c..dule.js gzip 6.21 kB 6.21 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/un-transpiled-file Change
_error.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +1.66 kB
link.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
routerDirect.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
withRouter.js 1.07 MB 1.07 MB ⚠️ +1.66 kB
Overall change 5.27 MB 5.28 MB ⚠️ +8.3 kB
Commit: 399a754

@kodiakhq kodiakhq bot merged commit 78ef139 into vercel:canary Aug 21, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spread operator not working in Safari 11.0.3

2 participants

@ijjk @Timer