KEMBAR78
Increase font test timeout for Windows by Timer · Pull Request #16527 · vercel/next.js · GitHub
Skip to content

Increase font test timeout for Windows #16527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2020
Merged

Increase font test timeout for Windows #16527

merged 3 commits into from
Aug 25, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 24, 2020

Let's see if this stabilizes things

@ijjk
Copy link
Member

ijjk commented Aug 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Timer/next.js font-timeout Change
buildDuration 12.2s 12.1s -57ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js font-timeout Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.327 2.325 0
/ avg req/sec 1074.16 1075.43 +1.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.483 1.347 -0.14
/error-in-render avg req/sec 1686.27 1855.48 +169.21
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7e72e5b..8b35.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e35d22e..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js font-timeout Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js font-timeout Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js font-timeout Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js font-timeout Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js font-timeout Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js font-timeout Change
buildDuration 13.9s 13.6s -320ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7e72e5b..8b35.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e35d22e..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js font-timeout Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js font-timeout Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js font-timeout Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js font-timeout Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js font-timeout Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 024d44d

@Timer Timer marked this pull request as ready for review August 24, 2020 22:16
@ijjk
Copy link
Member

ijjk commented Aug 25, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Timer/next.js font-timeout Change
buildDuration 13.7s 13.3s -398ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js font-timeout Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.507 2.496 -0.01
/ avg req/sec 997.28 1001.57 +4.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.498 1.553 ⚠️ +0.05
/error-in-render avg req/sec 1669.37 1610.27 ⚠️ -59.1
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7e72e5b..8b35.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e35d22e..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js font-timeout Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js font-timeout Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js font-timeout Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js font-timeout Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js font-timeout Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary Timer/next.js font-timeout Change
buildDuration 15.7s 15.2s -504ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7e72e5b..8b35.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js font-timeout Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e35d22e..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js font-timeout Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js font-timeout Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js font-timeout Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js font-timeout Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js font-timeout Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 1bea134

timneutkens
timneutkens approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it doesn't but let's still land this change 👍

@Timer Timer merged commit 34f737c into vercel:canary Aug 25, 2020
@Timer Timer deleted the font-timeout branch August 25, 2020 14:41
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Timer @ijjk @timneutkens