fix(dev-overlay): prevent hydration mismatch in dialog role #83718
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog component was initializing role state with document.hasFocus(), which caused different HTML between server and client. This patch moves the logic into useEffect so that initial render is consistent and hydration succeeds without warnings.
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/next/src/next-devtools/dev-overlay/components/dialog/dialog.tsx
Outdated
Show resolved
Hide resolved
…dialog.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed a hydration mismatch in the Next.js development overlay related to the dialog component. The issue occurred because the component initialized role state with document.hasFocus(), causing server-rendered HTML to differ from client-rendered HTML.
Why?
Hydration mismatches lead to runtime warnings and inconsistent UI behavior in React applications. This fix ensures that the server-rendered markup matches the client-rendered markup, improving developer experience and preventing errors in the dev overlay.
How?
Closes / Fixes
fixes #83710