KEMBAR78
fix: Resolves captions sizing issue when minified (v7) by taylor5892 · Pull Request #9012 · videojs/video.js · GitHub
Skip to content

fix: Resolves captions sizing issue when minified (v7) #9012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix: Resolves captions sizing issue when minified (v7) #9012

merged 2 commits into from
Mar 20, 2025

Conversation

@taylor5892
Copy link

Resolves captions sizing issue when minified #8442

Description

This bug discussed and confirmed. A fix has been released shortly for videojs8 but verison 7 still haven't fixed. #8370

Specific Changes proposed

Same fix applied at #8442

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@taylor5892
Update text-track.js
4952127 
Resolves captions sizing issue when minified videojs#8442
@welcome
Copy link

welcome bot commented Mar 19, 2025

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

❌ Deploy Preview for zesty-marshmallow-73319e failed.

Name Link
🔨 Latest commit 4952127
🔍 Latest deploy log https://app.netlify.com/sites/zesty-marshmallow-73319e/deploys/67da355c26a1f800083efcda

mister-ben
mister-ben approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov upload fails because of changes in codecov which have been addressed in v8, but we know this won't affect coverage.

@mister-ben mister-ben changed the title Update text-track.js fix: Resolves captions sizing issue when minified (v7) Mar 19, 2025
@mister-ben mister-ben merged commit 71641aa into videojs:7.x Mar 20, 2025
11 of 12 checks passed
@welcome
Copy link

welcome bot commented Mar 20, 2025

Congrats on merging your first pull request! 🎉🎉🎉

@taylor5892 taylor5892 deleted the patch-1 branch March 20, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkatsev gkatsev gkatsev approved these changes

@mister-ben mister-ben mister-ben approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor5892 @gkatsev @mister-ben