[css-backgrounds-3][css-borders-4] Fixed definition for where box shadows apply #9296
Conversation
There was a problem hiding this comment.
So I was expecting the behavior to be the principal box since that's the simple choice, but I have tried a table:
<!DOCTYPE html>
<table style="outline: 3px solid cyan; box-shadow: 0 0 0 6px magenta">
<caption>Tablecaption</caption>
<tr><td>cell</td></tr>
</table>Both Firefox and Chromium apply the shadow to the table grid box, not to the principal table wrapper box.
So maybe it should be discussed whether this should change? Or say that it's the principal box unless otherwise defined by the relevant spec (https://www.w3.org/TR/CSS21/tables.html#model would imply table grid box, and seemingly https://drafts.csswg.org/css-tables/#global-style-overrides too)
I can't find it now, but I remember some discussion about defaulting properties on a table to apply to the principal wrapper box, with some exceptions that apply to the grid box. Now the default is the grid box, which seems a bit weird.
| <li>Fixed an error in the Computed Value line of 'background-image'. | ||
| (<a href="https://github.com/w3c/csswg-drafts/issues/8604">Issue 8604</a>) | ||
| <li>Fixed the definition for where box shadows apply. | ||
| (<a href="https://github.com/w3c/csswg-drafts/issues/9286">Issue 9286</a>) |
There was a problem hiding this comment.
This is in the "Changes since the 14 February 2024 Candidate Recommendation Snapshot" which doesn't exist (should be 2023 instead).
There was a problem hiding this comment.
Not sure whether @fantasai's comment was related to this, though I went ahead and fixed this obvious mistake.
There was a problem hiding this comment.
No, I was commenting on the actual spec text.
|
@Loirooriol Can you drop that comment into the issue? |
css-backgrounds-3/Overview.bs
Outdated
|
|
||
| <p>If an element has multiple boxes, all of them get drop shadows, | ||
| <p>Drop shadows are only applied to the [=principal box=]. | ||
| If that box has multiple [=fragments=], then all of them get shadows, |
There was a problem hiding this comment.
This is incorrect. How box-shadow is handled on fragments depends on box-decoration-break, see https://www.w3.org/TR/css-break-4/#break-decoration
There was a problem hiding this comment.
Isn't this addressed in the next sentence?
but shadows are only drawn where borders would also be drawn;
see 'box-decoration-break'.
There was a problem hiding this comment.
No, it's not that we have multiple shadows some parts of which aren't drawn. box-decoration-break determines whether the entire box gets shadowed and then sliced or the fragments get shadowed. If you offset the shadow by more than the width of the first fragment and then blur it, for example, the first fragment won't have a shadow attached, but there will be a shadow as wide as the combined fragments, blurred as a single unit, attached to the second fragment.
css-backgrounds-3/Overview.bs
Outdated
| <p>If an element has multiple boxes, all of them get drop shadows, | ||
| <p>Drop shadows are only applied to the [=principal box=]. | ||
| If that box has multiple [=fragments=], then all of them get shadows, |
There was a problem hiding this comment.
<p>Unless otherwise specified, drop shadows are only applied to the [=principal box=].
If the affected box has multiple fragments,
the shadows are applied as specified in 'box-decoration-break'.
SebastianZ
force-pushed
the
9286-drop-shadows-applying-to-principal-box
branch
from
82e2238 to
7190233
Compare
SebastianZ
force-pushed
the
9286-drop-shadows-applying-to-principal-box
branch
from
7190233 to
4a0b8ab
Compare
SebastianZ
force-pushed
the
9286-drop-shadows-applying-to-principal-box
branch
from
baacc5d to
9b6b48f
Compare
I made up for that now. Sebastian |
SebastianZ
force-pushed
the
9286-drop-shadows-applying-to-principal-box
branch
from
f727a92 to
befc123
Compare
|
@Loirooriol @fantasai Can you please have another look? Sebastian |
3 participants
This corrects the description for where box shadows are applied.
Fixes #9286