KEMBAR78
Change the requirement for progressive enhancement with spine-level scripting by mattgarrish · Pull Request #1467 · w3c/epub-specs · GitHub
Skip to content

Change the requirement for progressive enhancement with spine-level scripting #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Change the requirement for progressive enhancement with spine-level scripting #1467

merged 2 commits into from
Jan 20, 2021

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Jan 13, 2021 •
edited by pr-preview bot
Loading

This PR fixes #1444 as follows:

  • changes the requirement for progressive enhancement to a recommendation that the top-level content documents remain consumable
  • progressive enhancement is moved to a parenthetical as one way of accomplishing this
  • adds context for why it is important that scripted top-level content documents be consumable

Preview | Diff

@mattgarrish
change the requirement for progressive enhancement with spine-level s…
e6cc166 
…cripting to a recommendation that top-level content documents remain consumable
iherman
iherman approved these changes Jan 13, 2021 •
edited
Loading
View reviewed changes
dauwhe
dauwhe approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@dauwhe dauwhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. I don't think we necessarily need a reference for "progressive enhancement." It's very easily searchable, and a term quite familiar to the web community.

@iherman iherman self-requested a review January 13, 2021 16:42
@dauwhe dauwhe merged commit 5210e86 into master Jan 20, 2021
@dauwhe dauwhe deleted the editorial/issue-1444 branch January 20, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iherman iherman iherman approved these changes

@shiestyle shiestyle shiestyle approved these changes

+2 more reviewers

@dauwhe dauwhe dauwhe approved these changes

@wareid wareid wareid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Normative restrictions on scripting: is it necessary?

5 participants

@mattgarrish @iherman @dauwhe @shiestyle @wareid