KEMBAR78
Clarify that data blocks are exempt from fallbacks by mattgarrish · Pull Request #2332 · w3c/epub-specs · GitHub
Skip to content

Clarify that data blocks are exempt from fallbacks #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2022
Merged

Clarify that data blocks are exempt from fallbacks #2332

merged 4 commits into from
Jun 17, 2022

Conversation

@mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Jun 10, 2022 •
edited by pr-preview bot
Loading

I've added a new section to the intrinsic fallbacks section to clarify that they're not needed for data blocks.

There are about three places this exemption could go, but this seemed the most logical. It could also go in a couple of places in the exempt resources section, but even if we consider them resources they aren't for use by reading systems which breaks the definition.

Fixes #2331

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jun 13, 2022, 12:27 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: http://labs.w3.org/spec-generator/uploads/fOB39g?isPreview=true&publishDate=2022-06-13
ReSpec version: 32.1.8
File a bug: https://github.com/w3c/respec/
Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 27316ms.
    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:110:16)
    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:221:12)
    at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:92:18)
    at async Object.generate [as respec] (file:///u/spec-generator/generators/respec.js:15:44)
    at async file:///u/spec-generator/server.js:247:48

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@iherman
Copy link
Member

iherman commented Jun 11, 2022

See:

iherman
iherman approved these changes Jun 11, 2022
View reviewed changes
@mattgarrish mattgarrish merged commit 7af6c12 into main Jun 17, 2022
@mattgarrish mattgarrish deleted the fix/issue-2331 branch June 17, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iherman iherman iherman approved these changes

@shiestyle shiestyle shiestyle approved these changes

@dauwhe dauwhe Awaiting requested review from dauwhe

@wareid wareid Awaiting requested review from wareid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Script data blocks and foreign resources

3 participants

@mattgarrish @iherman @shiestyle