KEMBAR78
Rearrange unsupported features by mattgarrish · Pull Request #2425 · w3c/epub-specs · GitHub
Skip to content

Rearrange unsupported features #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2022
Merged

Rearrange unsupported features #2425

merged 4 commits into from
Sep 16, 2022

Conversation

@mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Sep 14, 2022 •
edited by pr-preview bot
Loading

This PR makes the following changes:

  • the explanation of "legacy features" is integrated into the existing package document section as these are the only legacy features
  • adds a new intro to try and explain that the legacy features only exist to allow epub 2 reading systems to open epub 3 content, and there probably isn't much use for them anymore
  • makes some minor tweaks to the legacy feature descriptions to better highlight that they're only for epub 2 reading systems
  • moves the reading system support requirement for legacy features to a new corresponding section in the reading system spec
  • also moves the under-implemented and deprecated support requirements to the RS spec

Fixes #2423
Fixes #2424

Preview | Diff

@mattgarrish
integrate explanation and support of legacy features into package doc…
f6a69b5 
…ument section;

move reading system requirements for unsupported features to the RS spec
@mattgarrish
add change log entries
b3222cd
iherman
iherman approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note to @dlazin : this PR introduce a new MUST statement that will require a test. The test structure could be to have both a nav and an ncx document in the publication, with the ncx being slightly different; the test passes if the ncx version is not visible.

@mattgarrish mattgarrish merged commit 3f97cdb into main Sep 16, 2022
@mattgarrish mattgarrish deleted the fix/issue-2424 branch September 16, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iherman iherman iherman approved these changes

@dauwhe dauwhe Awaiting requested review from dauwhe

@shiestyle shiestyle Awaiting requested review from shiestyle

+1 more reviewer

@wareid wareid wareid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reading system requirements in the authoring spec Explain legacy elements

3 participants

@mattgarrish @iherman @wareid