Mark the rtl dir value under-implemented #2515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where in the package document there is a dir="rtl"? |
|
The root element and all elements that accept text allow dir. See the diff. |
iherman
approved these changes
Jan 10, 2023
iherman
approved these changes
Jan 10, 2023
shiestyle
approved these changes
Jan 11, 2023
dauwhe
approved these changes
Jan 11, 2023
…ote explaining why it is still important to set; adds note to the RS spec to explain that reading systems need to support the attribute despite the authoring label
…o fix/dir-label # Conflicts: # epub33/core/index.html # epub33/rs/index.html
iherman
requested changes
Jan 11, 2023
Comment on lines
+2703
to
+2704
| <li>11-Jan-2023: Removed support description for under-implemented features. See <a | ||
| href="https://github.com/w3c/epub-specs/pull/2515">pull request 2515</a>.</li> |
There was a problem hiding this comment.
I guess this is based on getting to an equilibrium point on MO, ie, that there is no under-implemented notion for MO at all (which is probably all right, because MO is not a required feature as a whole).
There was a problem hiding this comment.
Either that or we do something similar where we under-implement the authoring feature. I made that change after the last call when it sounded like we wouldn't have to label MO because it's only a recommended feature. It's easy to get back the prose if we need it, though.
iherman
approved these changes
Jan 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the 2023-01-05 telecon, there are support gaps for the
dirattribute in the package document. Looking at the tests, these failures appear to all be centred around support for thertlvalue.Consequently, rather than mark the whole attribute under-implemented, this PR only adds the label to the
rtlvalue. This is in keeping with how theportraitvalue forrendition:spreadis deprecated.If I've misread the test results and we need to consider a whole-attribute labelling, please feel free to say so, though.
And as this looks like it could be the only under-implemented feature we'll have, and we want reading systems to support it moving forward, it doesn't make sense to me to label it in the Reading Systems specification. It seems to undermine the goal of getting support improved. Can we limit ourselves only to warning authors? And, similarly, can we remove the text in the RS appendix about not having to support under-implemented features?
Preview | Diff