KEMBAR78
176 map and area updates by scottaohara · Pull Request #187 · w3c/html-aam · GitHub
Skip to content

176 map and area updates #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2019
Merged

176 map and area updates #187

merged 5 commits into from
May 21, 2019

Conversation

@scottaohara
Copy link
Member

@scottaohara scottaohara commented May 21, 2019 •
edited by pr-preview bot
Loading

Closes #176

Adds area accessible name and accessible description computation steps.

Updates map's mapping to match what is reported by AXAPI in different situations.

Preview | Diff

@scottaohara scottaohara requested a review from stevefaulkner May 21, 2019 11:04
stevefaulkner
stevefaulkner reviewed May 21, 2019
View reviewed changes
index.html
<link href="https://rawgit.com/w3c/aria/master/common/css/mapping-tables.css" rel="stylesheet" />
<link href="https://rawgit.com/w3c/aria/master/common/css/common.css" rel="stylesheet" />
<link href="https://rawgit.com/w3c/aria/master/common/css/mapping-tables.css" rel="stylesheet">
<link href="https://rawgit.com/w3c/aria/master/common/css/common.css" rel="stylesheet">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why we are pointing to "https://rawgit.com/..."

Copy link
Contributor

@stevefaulkner stevefaulkner May 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch that saw note below
<!-- Temporary replacement of these 4 script references to JS resources at rawgit.com with local sources until common solution for resources like these shared among different AAMs is found -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not on a gh-pages branch?

marcoscaceres
marcoscaceres reviewed May 21, 2019
View reviewed changes
index.html
<link href="https://rawgit.com/w3c/aria/master/common/css/mapping-tables.css" rel="stylesheet" />
<link href="https://rawgit.com/w3c/aria/master/common/css/common.css" rel="stylesheet" />
<link href="https://rawgit.com/w3c/aria/master/common/css/mapping-tables.css" rel="stylesheet">
<link href="https://rawgit.com/w3c/aria/master/common/css/common.css" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not on a gh-pages branch?

@scottaohara scottaohara merged commit 96385da into gh-pages May 21, 2019
@scottaohara scottaohara deleted the 176_map_area branch May 21, 2019 15:46
@scottaohara scottaohara mentioned this pull request May 21, 2019
Closed
@marcoscaceres
Copy link
Member

We should set up some time to chat about how to use data-cite and automatic cross references in ReSpec. We should never need to include absolute URLs in the spec, specially ones to the HTML spec.

Happy to do some training for folks here!

@scottaohara
Copy link
Member Author

I think that's a good idea @marcoscaceres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevefaulkner stevefaulkner stevefaulkner approved these changes

@marcoscaceres marcoscaceres marcoscaceres left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There's no name computation for the area element

3 participants

@scottaohara @marcoscaceres @stevefaulkner