Adds language to expand 'not mapped' definition #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #151 While there are many elements that would have originally fallen under this issue... on a long enough timeline everything maps to `generic`. So is the resolution to this issue. There are a few remaining HTML elements that are not mapped because they are not rendered by browsers. For the few instances of these where users can force render them (e.g., making a `style` element `display: block` for reasons) then these elements would and should be largely exposed as `generic` elements. From quick review, the only one in question here of not mapping to `generic` is `link`. But also, if you're force rendering a `link` element... then...
cookiecrook
approved these changes
Oct 25, 2022
cookiecrook
approved these changes
Oct 25, 2022
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #151
While there are many elements that would have originally fallen under this issue... on a long enough timeline everything maps to
generic.So is the resolution to this issue. There are a few remaining HTML elements that are not mapped because they are not rendered by browsers. For the few instances of these where users can force render them (e.g., making a
styleelementdisplay: blockfor reasons) then these elements would and should be largely exposed asgenericelements. From quick review, the only one in question here of not mapping togenericislink. But also, if you're force rendering alinkelement... then...Preview | Diff