This repository was archived by the owner on Aug 27, 2021. It is now read-only.
better integration with PR API #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsolomakhin
approved these changes
Apr 5, 2018
marcoscaceres
changed the title
marcoscaceres
changed the title
This was referenced Apr 30, 2018
marcoscaceres
force-pushed
the
rsolomakhin-gh-pages
branch
from
369dc31 to
e507b37
Compare
ianbjacobs
reviewed
May 4, 2018
| <li>For each <var>card</var> in <var>cards</var>: | ||
| <ol> | ||
| <li>If <a>instrument is supported</a> <var>card</var>, | ||
| <var>networks</var>, <var>types</var> returns true, return true. |
There was a problem hiding this comment.
Hi @marcoscaceres, line 258 looks to be missing some punctuation (I think).
|
@marcoscaceres, sorry to have missed your review request. I read tonight and on first pass it looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement of w3c/payment-request#700
redact phone number (closes #5)
Preview | Diff