Remove note since in practice we have a 1.1 branch #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Nov 14, 2022
|
Having said that... it would be good if the versioning now went away entirely. |
|
@ianbjacobs, just a quick reminder to always add "Editorial:" to commit messages when merging. 🙏 Then ReSpec knows to omit those commit messages from the change log in the spec itself. |
|
Oops. Thank you for the reminder. Can it be added after the fact? |
It can, but it makes a mess for anyone that's forked the repo (as their main branch history will no longer match). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff