KEMBAR78
Feat: adds PaymentItemType enum and PaymentItem.type by marcoscaceres · Pull Request #666 · w3c/payment-request · GitHub
Skip to content

Feat: adds PaymentItemType enum and PaymentItem.type #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2018
Merged

Feat: adds PaymentItemType enum and PaymentItem.type #666

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b98e53
Feat: adds PaymentItemType enum and PaymentItem.type
marcoscaceres Jan 17, 2018
d7bb87f
Make PaymentItem.type nullable
marcoscaceres Jan 19, 2018
d0a11f2
tests: link to PaymentItem/type_member.https.html
marcoscaceres Jan 19, 2018
7876653
Revert nullable type
marcoscaceres Jan 22, 2018
2c16356
review feedback
marcoscaceres Jan 22, 2018
a5dbf13
Mark as at risk
marcoscaceres Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ <h2>
<a href="https://github.com/w3c/payment-request/issues/617">issue
617</a>).
</li>
<li data-link-for="PaymentItem">
<a>PaymentItem</a>'s <a>type</a> member and the
<a>PaymentItemType</a> enum (see <a href=
"https://github.com/w3c/payment-request/issues/163">issue 163</a>).
</li>
</ul>
</section>
</section>
Expand Down Expand Up @@ -281,6 +286,7 @@ <h3>
{
label: "Sales Tax",
amount: { currency: "USD", value: "5.00" },
type: "tax"
},
],
total: {
Expand Down Expand Up @@ -1848,6 +1854,8 @@ <h2>
required DOMString label;
required PaymentCurrencyAmount amount;
boolean pending = false;
// Note: type member is "at risk" of being removed!
PaymentItemType type;
};
</pre>
<p>
Expand Down Expand Up @@ -1881,7 +1889,63 @@ <h2>
the user interface for the payment request.
</dd>
</dl>
<div class="issue atrisk">
<p>
This feature has been marked "<a>at risk</a>". Firefox plans to
experiment with this feature during the Candidate Recommendation
phase. If you'd like for this feature to remain in the specification,
please signal your support for it to remain in <a href=
"https://github.com/w3c/payment-request/issues/163">issue 163</a>.
</p>
<dl>
<dt>
<dfn>type</dfn> member
</dt>
<dd data-tests="PaymentItem/type_member.https.html">
A <a>PaymentItemType</a> enum value, which a developer can use to
explicitly indicate that this member is of a particular type. A
user agent MAY use the value of <a>type</a> to assist in the
presentation of <a>PaymentItem</a> by, for example, visually
grouping types together or other otherwise distinguishing them from
other types (or from items that have no associated type).
</dd>
<dd></dd>
</dl>
</div>
</section>
<div class="issue atrisk">
<p>
This feature has been marked "<a>at risk</a>". Firefox plans to
experiment with this feature during the Candidate Recommendation phase.
If you'd like for this feature to remain in the specification, please
signal your support for it to remain in <a href=
"https://github.com/w3c/payment-request/issues/163">issue 163</a>.
</p>
<section data-dfn-for="PaymentItemType">
<h2>
<dfn>PaymentItemType</dfn> enum
</h2>
<pre class="idl">
enum PaymentItemType {
"tax"
};
</pre>
<p>
The <a>PaymentItemType</a> serves to categorize a <a>PaymentItem</a>
into particular types.
</p>
<dl>
<dt>
"<dfn>tax</dfn>"
</dt>
<dd>
Indicates that the corresponding <a>PaymentItem</a> represents a form
of taxation. Examples include sales tax, goods and services tax,
value added tax, an so on.
</dd>
</dl>
</section>
</div>
<section data-dfn-for="PaymentAddress" data-link-for="PaymentAddress">
<h2>
<dfn>PaymentAddress</dfn> interface
Expand Down