KEMBAR78
Add error member to PaymentValidationErrors by marcoscaceres · Pull Request #747 · w3c/payment-request · GitHub
Skip to content

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 5, 2018

closes #729

The following tasks have been completed:

Implementation commitment:

  • Safari - already implemented.
  • Chrome
  • Firefox
  • Edge (public signal)

Impact on Payment Handler spec?


Preview | Diff

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, does this feature have consensus? #729 was a bit light on details.

Also will need rebase.

@marcoscaceres
Copy link
Member Author

@rsolomakhin, could you confirm that this is ok from the Blink side? We are planning to implement in Gecko. @aestes said this was ok to support in WebKit.

@marcoscaceres
Copy link
Member Author

Gecko tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1473081

Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoscaceres
Copy link
Member Author

Sent test web-platform-tests/wpt#12394

@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres merged commit 0273c79 into gh-pages Aug 10, 2018
@marcoscaceres marcoscaceres deleted the error_member branch August 10, 2018 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic error member for .retry()

3 participants